Commit d999e6af authored Mar 08, 2018 by Shuhei Matsumoto Committed by Jim Harris Mar 08, 2018

iscsi: Move connection init right after iSCSI global params init



Pool of iSCSI connections and related variables are initialized in
initialize_iscsi_conns().

Currently initialize_iscsi_conns() is located after configuration of
target nodes by .INI config file.

Configuration of target nodes can be done by JSON-RPC but connection
initialization must be completed before starting JSON-RPC.

iSCSI connections don't belong to iSCSI global params directly and
hence move connection initialization right after initialization of
iSCSI global params.

The purpose of the patch series is
- to separate iSCSI subsystem initialization and iSCSI subsystem
  configuration, and
- to develop a new JSON-RPC by reusing the separated iSCSI subsystem
  initialization.

Change-Id: I183365b84aa205790b27adf7cc1f632b932195aa
Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-on: https://review.gerrithub.io/403143


Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>

parent 180af18c

lib/iscsi/iscsi_subsystem.c

+7 −7

Original line number	Diff line number	Diff line
		@@ -931,6 +931,13 @@ spdk_iscsi_init(spdk_iscsi_init_cb cb_fn, void *cb_arg)
		return;
		}

		rc = spdk_initialize_iscsi_conns();
		if (rc < 0) {
		SPDK_ERRLOG("spdk_initialize_iscsi_conns() failed\n");
		spdk_iscsi_init_complete(-1);
		return;
		}

		rc = spdk_iscsi_portal_grp_array_create();
		if (rc < 0) {
		SPDK_ERRLOG("spdk_iscsi_portal_grp_array_create() failed\n");
		@@ -952,13 +959,6 @@ spdk_iscsi_init(spdk_iscsi_init_cb cb_fn, void *cb_arg)
		return;
		}

		rc = spdk_initialize_iscsi_conns();
		if (rc < 0) {
		SPDK_ERRLOG("spdk_initialize_iscsi_conns() failed\n");
		spdk_iscsi_init_complete(-1);
		return;
		}

		spdk_initialize_iscsi_poll_group();
		}