Commit d97d1aa5 authored by Karol Latecki's avatar Karol Latecki Committed by Tomasz Zawadzki
Browse files

test/make: remove redundant ls from ABI test 



"ls" is not needed in for loops based on filename
expansions.
Additionally "ls" was treated as first
element of for loop which cased "No corresponding
object" message to be printed which could be
mistakenly considered a problem during the build.

Signed-off-by: default avatarKarol Latecki <karol.latecki@intel.com>
Change-Id: If5bfdb15410da36c98d9992cd04a02906599a3e0
Signed-off-by: default avatarKarol Latecki <karol.latecki@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1411


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@mellanox.com>
parent 3c92d9f1

test/make/check_so_deps.sh

+1 −1
Original line number Diff line number Diff line
@@ -23,7 +23,7 @@ function confirm_abi_deps() { 
		return 1

	fi



	for object in ls "$libdir"/libspdk_*.so; do

	for object in "$libdir"/libspdk_*.so; do

		so_file=$(basename $object)

		if [ ! -f "$source_abi_dir/$so_file" ]; then

			echo "No corresponding object for $so_file in canonical directory. Skipping."