Commit d7a7ef61 authored by Tomasz Zawadzki's avatar Tomasz Zawadzki Committed by Jim Harris
Browse files

scsi: spdk_bdev_scsi_reset() now returns void 



SCSI reset function return code is not used,
so there is no need for it to have return code.

Change-Id: Ib647109c75b1546675d2601fa00004e1ef186024
Signed-off-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-on: https://review.gerrithub.io/418615


Tested-by: default avatarSPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
parent 6f9e81ee

lib/scsi/scsi_bdev.c

+2 −3
Original line number Diff line number Diff line
@@ -2033,11 +2033,10 @@ spdk_bdev_scsi_execute(struct spdk_scsi_task *task) 
	return rc;

}



int

void

spdk_bdev_scsi_reset(struct spdk_scsi_task *task)

{

	struct spdk_scsi_lun *lun = task->lun;



	return spdk_bdev_reset(lun->bdev_desc, lun->io_channel,

			       spdk_bdev_scsi_task_complete_mgmt, task);

	spdk_bdev_reset(lun->bdev_desc, lun->io_channel, spdk_bdev_scsi_task_complete_mgmt, task);

}

lib/scsi/scsi_internal.h

+1 −1
Original line number Diff line number Diff line
@@ -136,7 +136,7 @@ int spdk_scsi_port_construct(struct spdk_scsi_port *port, uint64_t id, 
void spdk_scsi_port_destruct(struct spdk_scsi_port *port);



int spdk_bdev_scsi_execute(struct spdk_scsi_task *task);

int spdk_bdev_scsi_reset(struct spdk_scsi_task *task);

void spdk_bdev_scsi_reset(struct spdk_scsi_task *task);



struct spdk_scsi_globals {

	pthread_mutex_t mutex;

test/unit/lib/scsi/lun.c/lun_ut.c

+2 −2
Original line number Diff line number Diff line
@@ -159,10 +159,10 @@ void spdk_scsi_dev_delete_lun(struct spdk_scsi_dev *dev, 
	return;

}



int

void

spdk_bdev_scsi_reset(struct spdk_scsi_task *task)

{

	return 0;

	return;

}



int