Commit d7760821 authored by Xiaodong Liu's avatar Xiaodong Liu Committed by Changpeng Liu
Browse files

bdev/raid: enable flush support 



FLUSH io_type shares a same process with UNMAP, except
that in the end, it calls spdk_bdev_flush_blocks function.

Change-Id: I4529bf29b7cd9f16d10f2edc99a20d25213c9c71
Signed-off-by: default avatarXiaodong Liu <xiaodong.liu@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/446492


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarPiotr Pelpliński <piotr.pelplinski@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: default avatarwuzhouhui <wuzhouhui@kingsoft.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
parent 32c888e5

lib/bdev/raid/bdev_raid.c

+8 −5
Original line number Diff line number Diff line
@@ -742,6 +742,13 @@ _raid_bdev_submit_null_payload_request_next(void *_bdev_io) 
						     raid_bdev_base_io_completion, bdev_io);

			break;



		case SPDK_BDEV_IO_TYPE_FLUSH:

			ret = spdk_bdev_flush_blocks(raid_bdev->base_bdev_info[disk_idx].desc,

						     raid_ch->base_channel[disk_idx],

						     offset_in_disk, nblocks_in_disk,

						     raid_bdev_base_io_completion, bdev_io);

			break;



		default:

			SPDK_ERRLOG("submit request, invalid io type with null payload %u\n", bdev_io->type);

			assert(false);
@@ -835,15 +842,11 @@ raid_bdev_submit_request(struct spdk_io_channel *ch, struct spdk_bdev_io *bdev_i 
		raid_bdev_start_rw_request(ch, bdev_io);

		break;



	case SPDK_BDEV_IO_TYPE_FLUSH:

		/* TODO: support flush if requirement comes */

		spdk_bdev_io_complete(bdev_io, SPDK_BDEV_IO_STATUS_SUCCESS);

		break;



	case SPDK_BDEV_IO_TYPE_RESET:

		_raid_bdev_submit_reset_request(ch, bdev_io);

		break;



	case SPDK_BDEV_IO_TYPE_FLUSH:

	case SPDK_BDEV_IO_TYPE_UNMAP:

		_raid_bdev_submit_null_payload_request(ch, bdev_io);

		break;

test/unit/lib/bdev/bdev_raid.c/bdev_raid_ut.c

+8 −0
Original line number Diff line number Diff line
@@ -306,6 +306,14 @@ spdk_bdev_unmap_blocks(struct spdk_bdev_desc *desc, struct spdk_io_channel *ch, 
	return g_bdev_io_submit_status;

}



int

spdk_bdev_flush_blocks(struct spdk_bdev_desc *desc, struct spdk_io_channel *ch,

		       uint64_t offset_blocks, uint64_t num_blocks,

		       spdk_bdev_io_completion_cb cb, void *cb_arg)

{

	return 0;

}



bool

spdk_bdev_io_type_supported(struct spdk_bdev *bdev, enum spdk_bdev_io_type io_type)

{