Commit d73d43a9 authored by Changpeng Liu's avatar Changpeng Liu Committed by Jim Harris
Browse files

nvmf/vfio-user: don't set ACTIVE state for ADMIN queue pair 



When doing live migration, the destination VM will construct
ADMIN queue pair at the beginning, but the controller isn't
in READY state, we should not poll the ADMIN queue pair right
now.  This is fine for normal controllers, normal controllers
will set ADMIN queue pair state in CC callback.

Change-Id: I0db36f75a463fb7476ee62323f9ed0c74c2451dc
Signed-off-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/10621


Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
parent 95dd9003

lib/nvmf/vfio_user.c

+1 −1
Original line number Diff line number Diff line
@@ -2919,7 +2919,6 @@ handle_queue_connect_rsp(struct nvmf_vfio_user_req *req, void *cb_arg) 


	vu_group = SPDK_CONTAINEROF(vu_sq->group, struct nvmf_vfio_user_poll_group, group);

	TAILQ_INSERT_TAIL(&vu_group->sqs, vu_sq, link);

	vu_sq->sq_state = VFIO_USER_SQ_ACTIVE;



	vu_cq = vu_ctrlr->cqs[0];

	assert(vu_cq != NULL);
@@ -2961,6 +2960,7 @@ handle_queue_connect_rsp(struct nvmf_vfio_user_req *req, void *cb_arg) 
			}

			vu_sq->post_create_io_sq_completion = false;

		}

		vu_sq->sq_state = VFIO_USER_SQ_ACTIVE;

	}



	TAILQ_INSERT_TAIL(&vu_ctrlr->connected_sqs, vu_sq, tailq);