Commit d6473178 authored by Jacek Kalwas's avatar Jacek Kalwas Committed by Tomasz Zawadzki
Browse files

nvme/auth: nullify poll status on auth done 



It is done unconditionally for two reasons:
To fix a spurious assertion after nvme_tcp_ctrlr_connect_qpair_poll in
nvme_tcp_ctrlr_disconnect_qpair and to prepare for the upcoming
code unification for the purpose of explicit fabric poll cleanup.

The change helps with the assertion because qpair->fabric_poll_status
is now cleared unconditionally, whereas previously it was omitted if
the timed_out flag was set.

Fixes #3745

Change-Id: I7223f244b6b453c17f9fd8bf3fdbda394554f10f
Signed-off-by: default avatarJacek Kalwas <jacek.kalwas@nutanix.com>
Reviewed-on: https://review.spdk.io/c/spdk/spdk/+/26799


Community-CI: Mellanox Build Bot
Tested-by: default avatarSPDK Automated Test System <spdkbot@gmail.com>
Reviewed-by: default avatarKonrad Sztyber <ksztyber@nvidia.com>
Reviewed-by: default avatarBen Walker <ben@nvidia.com>
parent 452833ad

lib/nvme/nvme_auth.c

+2 −2
Original line number Diff line number Diff line
@@ -1205,8 +1205,8 @@ nvme_fabric_qpair_authenticate_poll(struct spdk_nvme_qpair *qpair) 
			nvme_auth_set_state(qpair, NVME_QPAIR_AUTH_STATE_DONE);

			break;

		case NVME_QPAIR_AUTH_STATE_DONE:

			if (qpair->fabric_poll_status != NULL && !status->timed_out) {

			qpair->fabric_poll_status = NULL;

			if (!status->timed_out) {

				spdk_free(status->dma_data);

				free(status);

			}