Commit d5e293de authored by Marcin Spiewak's avatar Marcin Spiewak Committed by Jim Harris
Browse files

lib/log: missing va_end() in spdk_vlog() 



Fixed issue detected by Coverity.

spdk_vlog() function uses va_copy() to initialize a copy of 'ap',
and va_end() must be called at the end of paramaters processing.
This patch adds this va_end() call, which was missing.

Change-Id: Ib097a2ccb298548d61c9f1be052df03bb11e55d0
Signed-off-by: default avatarMarcin Spiewak <marcin.spiewak@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24756


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: default avatarJim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot
parent 4e88e38c

lib/log/log.c

+1 −0
Original line number Diff line number Diff line
@@ -170,6 +170,7 @@ spdk_vlog(enum spdk_log_level level, const char *file, const int line, const cha 
			buf = ext_buf;

		}

	}

	va_end(ap_copy);



	if (level <= g_spdk_log_print_level) {

		get_timestamp_prefix(timestamp, sizeof(timestamp));