Commit d58eef2a authored by Alex Michon's avatar Alex Michon Committed by Jim Harris
Browse files

nvme/rdma: Fix reinserting qpair in connecting list after stale state



When a qpair is first created, we add it to a list of connecting qpairs.
If the connection fails, we move the qpair to a stale state and we retry
later. At this point, we should not add the qpair again to the
connecting qpairs list.

Change-Id: If38a8a51d3cb86f4d52d926d1acc349af21a6947
Signed-off-by: default avatarAlex Michon <amichon@kalrayinc.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25526


Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarJim Harris <jim.harris@nvidia.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Mellanox Build Bot
parent 2104eacf
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -1277,7 +1277,7 @@ nvme_rdma_ctrlr_connect_qpair(struct spdk_nvme_ctrlr *ctrlr, struct spdk_nvme_qp

	rqpair->state = NVME_RDMA_QPAIR_STATE_INITIALIZING;

	if (qpair->poll_group != NULL) {
	if (qpair->poll_group != NULL && rqpair->link_connecting.tqe_prev == NULL) {
		group = nvme_rdma_poll_group(qpair->poll_group);
		TAILQ_INSERT_TAIL(&group->connecting_qpairs, rqpair, link_connecting);
	}