Commit d53fcd40 authored Feb 09, 2024 by Jim Harris Committed by Tomasz Zawadzki Mar 04, 2024

test/unit/lib/scsi: remove SPDK_LIB_LIST += trace from scsi.c Makefile



This is already included in spdk.unittest.mk.

While here, also include "common/lib/test_env.c" in this unit test. Leaving it
out seems to have been working by accident - some upcoming patches caused
this file to fail linking for indirect reasons.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: I8fd6efbcfd27709d526bfffb02abc270280ffe38
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21814


Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>

parent 8a17ce8b

test/unit/lib/scsi/scsi.c/Makefile

+0 −1

Original line number	Diff line number	Diff line
		@@ -5,7 +5,6 @@

		SPDK_ROOT_DIR := $(abspath $(CURDIR)/../../../../..)

		SPDK_LIB_LIST = trace
		TEST_FILE = scsi_ut.c

		include $(SPDK_ROOT_DIR)/mk/spdk.unittest.mk

test/unit/lib/scsi/scsi.c/scsi_ut.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -10,6 +10,7 @@
		#include "spdk_internal/cunit.h"

		#include "scsi/scsi.c"
		#include "common/lib/test_env.c"

		static void
		scsi_init(void)