Commit d53bfa72 authored by Jim Harris's avatar Jim Harris Committed by Ben Walker
Browse files

test/nvmf: allow user to pass transport type to nvmf.sh 



Change autotest.sh to pass --transport=rdma.  But this
now allows someone to run nvmf.sh with --transport=tcp
to run all of the nvmf tests with the tcp transport!

Initial testing shows that bdevio.sh fails with tcp,
so only run this test with the rdma transport.  Issue
#808 has been filed - once it's resolved this
restriction can be removed.

Signed-off-by: default avatarJim Harris <james.r.harris@intel.com>
Change-Id: Ie50de4d67e504c84d6d8eebfe2b8c68b14f4ba2b

Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/456698


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarDarek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarSeth Howell <seth.howell5141@gmail.com>
parent c4d5d2fd

autotest.sh

+1 −1
Original line number Diff line number Diff line
@@ -207,7 +207,7 @@ if [ $SPDK_RUN_FUNCTIONAL_TEST -eq 1 ]; then 
	fi



	if [ $SPDK_TEST_NVMF -eq 1 ]; then

		run_test suite ./test/nvmf/nvmf.sh

		run_test suite ./test/nvmf/nvmf.sh --transport=rdma

		run_test suite ./test/spdkcli/nvmf.sh

	fi

test/nvmf/nvmf.sh

+5 −2
Original line number Diff line number Diff line
@@ -13,7 +13,7 @@ timing_enter nvmf_tgt 


trap "exit 1" SIGINT SIGTERM EXIT



TEST_ARGS=--transport=rdma

TEST_ARGS=$@



run_test suite test/nvmf/target/filesystem.sh $TEST_ARGS

run_test suite test/nvmf/target/discovery.sh $TEST_ARGS
@@ -36,7 +36,10 @@ fi 
run_test suite test/nvmf/target/nmic.sh $TEST_ARGS

run_test suite test/nvmf/target/rpc.sh $TEST_ARGS

run_test suite test/nvmf/target/fio.sh $TEST_ARGS

# bdevio currently fails with tcp transport - see issue #808

if [ "$TEST_TRANSPORT" == "rdma" ]; then

    run_test suite test/nvmf/target/bdevio.sh $TEST_ARGS

fi



timing_enter host