Commit d5102d37 authored by Changpeng Liu's avatar Changpeng Liu Committed by Jim Harris
Browse files

nvmf/vfio-user: process NVMe response cdw0 correctly 



The NVMf library will set cdw0 based on specific command,
so we use it directly in vfio-user, otherwise, some NVMe
commands such as AER can't work.

Fix issue #2016.

Change-Id: Ie1a80a92c0856b61822ee51ce5d8faaaf1d463de
Signed-off-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/8556


Reviewed-by: default avatarZiye Yang <ziye.yang@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
parent e34ad3e2

lib/nvmf/vfio_user.c

+2 −11
Original line number Diff line number Diff line
@@ -579,7 +579,7 @@ handle_cmd_req(struct nvmf_vfio_user_ctrlr *ctrlr, struct spdk_nvme_cmd *cmd, 
 * @ctrlr: the vfio-user controller

 * @cmd: the NVMe command for which the completion is posted

 * @cq: the completion queue

 * @cdw0: cdw0 as reported by NVMf (only for SPDK_NVME_OPC_GET/SET_FEATURES)

 * @cdw0: cdw0 as reported by NVMf

 * @sc: the NVMe CQE status code

 * @sct: the NVMe CQE status code type

 */
@@ -617,20 +617,11 @@ post_completion(struct nvmf_vfio_user_ctrlr *ctrlr, struct spdk_nvme_cmd *cmd, 
		      ctrlr_id(ctrlr), qid, cmd->cid, sc, ctrlr->qp[qid]->sq.head,

		      cq->tail);



	if (qid == 0) {

		switch (cmd->opc) {

		case SPDK_NVME_OPC_SET_FEATURES:

		case SPDK_NVME_OPC_GET_FEATURES:

			cpl->cdw0 = cdw0;

			break;

		}

	}





	assert(ctrlr->qp[qid] != NULL);



	cpl->sqhd = ctrlr->qp[qid]->sq.head;

	cpl->cid = cmd->cid;

	cpl->cdw0 = cdw0;

	cpl->status.dnr = 0x0;

	cpl->status.m = 0x0;

	cpl->status.sct = sct;