Commit d4767026 authored Aug 12, 2024 by Jim Harris Committed by Ben Walker Aug 13, 2024

test/unit: only run fsdev unit test when SPDK_CONFIG_FSDEV is defined



Previously this was guarded by a 'Linux' check, but it is still
possible that fsdev_ut wasn't built, if the config option wasn't set.
This especially would happen for anyone rebasing from master,
rebuilding and running unittest.sh *without* a re-configure - in that
case the new SPDK_CONFIG_FSDEV wouldn't get generated.

configure script will make sure this doesn't get defined for FreeBSD,
so it no longer needed to be inside of the 'Linux' check.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: I77b21cf9b9545b4de9722b1a382fafe5c18879b4
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24521


Reviewed-by: Tomasz Zawadzki <tomasz@tzawadzki.com>
Reviewed-by: Anisa Su <anisa.su@samsung.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Anton Nayshtut <anayshtut@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <ben@nvidia.com>

parent 342eca0d

test/unit/unittest.sh

+3 −2

Original line number	Diff line number	Diff line
		@@ -281,12 +281,13 @@ if [ $(uname -s) = Linux ]; then
		# There are several intermittent sock_ut failures on FreeBSD that need to be debugged.
		# So just disable running it on FreeBSD for now. See issue #2943.
		run_test "unittest_sock" unittest_sock
		# fsdev are only avaliable on Linux
		run_test "unittest_fsdev" unittest_fsdev
		fi
		run_test "unittest_thread" $valgrind $testdir/lib/thread/thread.c/thread_ut
		run_test "unittest_iobuf" $valgrind $testdir/lib/thread/iobuf.c/iobuf_ut
		run_test "unittest_util" unittest_util
		if grep -q '#define SPDK_CONFIG_FSDEV 1' $rootdir/include/spdk/config.h; then
		run_test "unittest_fsdev" unittest_fsdev
		fi
		if grep -q '#define SPDK_CONFIG_VHOST 1' $rootdir/include/spdk/config.h; then
		run_test "unittest_vhost" $valgrind $testdir/lib/vhost/vhost.c/vhost_ut
		fi

Admin message