Commit d3e394ae authored Mar 29, 2022 by Shuhei Matsumoto Committed by Tomasz Zawadzki Apr 04, 2022

module/bdev: Send not boolean false but error response for deletion RPCs



For deletion RPCs, a boolean false response had been sent rather than
a error response when they failed. However, boolean false resonse had
caused false negative, that is, test code had regarded as success by
mistake. For example, the following test code regards as success if
JSON RPC returns a boolean false response.

	if $rpc_py bdev_pmem_delete $pmem_bdev_name; then
		error "bdev_pmem_delete deleted pmem bdev for second time!"
	fi

This patch fixes such false negative issue by explicitly returning a
error response if deletion RPCs fail.

Only the bdev_virtio_detach_controller RPC has implemented this.

Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: I5409a070cbd2364dbb63b42421b032534c6f9a0b
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/12077


Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: John Kariuki <John.K.Kariuki@intel.com>

parent 96c007d3

module/bdev/aio/bdev_aio_rpc.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -168,7 +168,11 @@ _rpc_bdev_aio_delete_cb(void *cb_arg, int bdeverrno)
		{
		struct spdk_jsonrpc_request *request = cb_arg;

		spdk_jsonrpc_send_bool_response(request, bdeverrno == 0);
		if (bdeverrno == 0) {
		spdk_jsonrpc_send_bool_response(request, true);
		} else {
		spdk_jsonrpc_send_error_response(request, bdeverrno, spdk_strerror(-bdeverrno));
		}
		}

		static void

module/bdev/crypto/vbdev_crypto_rpc.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -309,7 +309,11 @@ rpc_bdev_crypto_delete_cb(void *cb_arg, int bdeverrno)
		{
		struct spdk_jsonrpc_request *request = cb_arg;

		spdk_jsonrpc_send_bool_response(request, bdeverrno == 0);
		if (bdeverrno == 0) {
		spdk_jsonrpc_send_bool_response(request, true);
		} else {
		spdk_jsonrpc_send_error_response(request, bdeverrno, spdk_strerror(-bdeverrno));
		}
		}

		static void

module/bdev/delay/vbdev_delay_rpc.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -187,7 +187,11 @@ rpc_bdev_delay_delete_cb(void *cb_arg, int bdeverrno)
		{
		struct spdk_jsonrpc_request *request = cb_arg;

		spdk_jsonrpc_send_bool_response(request, bdeverrno == 0);
		if (bdeverrno == 0) {
		spdk_jsonrpc_send_bool_response(request, true);
		} else {
		spdk_jsonrpc_send_error_response(request, bdeverrno, spdk_strerror(-bdeverrno));
		}
		}

		static void

module/bdev/error/vbdev_error_rpc.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -135,7 +135,11 @@ rpc_bdev_error_delete_cb(void *cb_arg, int bdeverrno)
		{
		struct spdk_jsonrpc_request *request = cb_arg;

		spdk_jsonrpc_send_bool_response(request, bdeverrno == 0);
		if (bdeverrno == 0) {
		spdk_jsonrpc_send_bool_response(request, true);
		} else {
		spdk_jsonrpc_send_error_response(request, bdeverrno, spdk_strerror(-bdeverrno));
		}
		}

		static void

module/bdev/ftl/bdev_ftl_rpc.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -230,7 +230,11 @@ rpc_bdev_ftl_delete_cb(void *cb_arg, int bdeverrno)
		{
		struct spdk_jsonrpc_request *request = cb_arg;

		spdk_jsonrpc_send_bool_response(request, bdeverrno == 0);
		if (bdeverrno == 0) {
		spdk_jsonrpc_send_bool_response(request, true);
		} else {
		spdk_jsonrpc_send_error_response(request, bdeverrno, spdk_strerror(-bdeverrno));
		}
		}

		static void