Commit d3526f52 authored by Shuhei Matsumoto's avatar Shuhei Matsumoto Committed by Jim Harris
Browse files

iscsi: Replace duplicated macro constant DEFAULT_FIRSTBURSTLENGTH 



Replace DEFAULT_FIRSTBURSTLENGTH by SPDK_ISCSI_FIRST_BURST_LENGTH.

Change-Id: Ia90ef714fab79dff4f9b9eb92ade8cfed3391450
Signed-off-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-on: https://review.gerrithub.io/c/444535


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarPawel Wodkowski <pawelx.wodkowski@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
parent 113db66a

lib/iscsi/iscsi.c

+1 −1
Original line number Diff line number Diff line
@@ -511,7 +511,7 @@ spdk_iscsi_read_pdu(struct spdk_iscsi_conn *conn, struct spdk_iscsi_pdu **_pdu) 
			 *  FirstBurstLength as our maximum data segment length

			 *  value.

			 */

			max_segment_len = DEFAULT_FIRSTBURSTLENGTH;

			max_segment_len = SPDK_ISCSI_FIRST_BURST_LENGTH;

		} else if (pdu->bhs.opcode == ISCSI_OP_SCSI_DATAOUT) {

			max_segment_len = spdk_get_data_out_buffer_size();

		} else if (pdu->bhs.opcode == ISCSI_OP_NOPOUT) {

lib/iscsi/iscsi.h

+0 −1
Original line number Diff line number Diff line
@@ -67,7 +67,6 @@ 
#define DEFAULT_MAXOUTSTANDINGR2T 1

#define DEFAULT_DEFAULTTIME2WAIT 2

#define DEFAULT_DEFAULTTIME2RETAIN 20

#define DEFAULT_FIRSTBURSTLENGTH 8192

#define DEFAULT_INITIALR2T true

#define DEFAULT_IMMEDIATEDATA true

#define DEFAULT_DATAPDUINORDER true

lib/iscsi/iscsi_subsystem.c

+1 −1
Original line number Diff line number Diff line
@@ -386,7 +386,7 @@ spdk_iscsi_opts_init(struct spdk_iscsi_opts *opts) 
	opts->MaxQueueDepth = DEFAULT_MAX_QUEUE_DEPTH;

	opts->DefaultTime2Wait = DEFAULT_DEFAULTTIME2WAIT;

	opts->DefaultTime2Retain = DEFAULT_DEFAULTTIME2RETAIN;

	opts->FirstBurstLength = DEFAULT_FIRSTBURSTLENGTH;

	opts->FirstBurstLength = SPDK_ISCSI_FIRST_BURST_LENGTH;

	opts->ImmediateData = DEFAULT_IMMEDIATEDATA;

	opts->AllowDuplicateIsid = false;

	opts->ErrorRecoveryLevel = DEFAULT_ERRORRECOVERYLEVEL;