Commit d238788b authored by Alexey Marchuk's avatar Alexey Marchuk Committed by Tomasz Zawadzki
Browse files

rdma: Handle IBV_EVENT_QP_FATAL in asynchronous way 



Send a message to the qpair thread to avoid modifying qpair
attributes in the acceptor poller thread which handles ibv events

Signed-off-by: default avatarAlexey Marchuk <alexeymar@mellanox.com>
Signed-off-by: default avatarSasha Kotchubievsky <sashakot@mellanox.com>
Signed-off-by: default avatarEvgeniy Kochetov <evgeniik@mellanox.com>
Change-Id: I8ea5658a2b226b0be9838eb375a8b80d15c456c5
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/476714


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarSeth Howell <seth.howell@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Community-CI: Broadcom SPDK FC-NVMe CI <spdk-ci.pdl@broadcom.com>
Community-CI: SPDK CI Jenkins <sys_sgci@intel.com>
parent dc84fbaa

lib/nvmf/rdma.c

+11 −2
Original line number Diff line number Diff line
@@ -3038,6 +3038,13 @@ spdk_nvmf_process_cm_event(struct spdk_nvmf_transport *transport, new_qpair_fn c 
	}

}



static void

nvmf_rdma_handle_qp_fatal(struct spdk_nvmf_rdma_qpair *rqpair)

{

	spdk_nvmf_rdma_update_ibv_state(rqpair);

	spdk_nvmf_rdma_start_disconnect(rqpair);

}



static void

nvmf_rdma_handle_last_wqe_reached(struct spdk_nvmf_rdma_qpair *rqpair)

{
@@ -3104,8 +3111,10 @@ spdk_nvmf_process_ib_event(struct spdk_nvmf_rdma_device *device) 
		SPDK_ERRLOG("Fatal event received for rqpair %p\n", rqpair);

		spdk_trace_record(TRACE_RDMA_IBV_ASYNC_EVENT, 0, 0,

				  (uintptr_t)rqpair->cm_id, event.event_type);

		spdk_nvmf_rdma_update_ibv_state(rqpair);

		spdk_nvmf_rdma_start_disconnect(rqpair);

		if (spdk_nvmf_rdma_send_qpair_async_event(rqpair, nvmf_rdma_handle_qp_fatal)) {

			SPDK_ERRLOG("Failed to send QP_FATAL event for rqpair %p\n", rqpair);

			nvmf_rdma_handle_qp_fatal(rqpair);

		}

		break;

	case IBV_EVENT_QP_LAST_WQE_REACHED:

		/* This event only occurs for shared receive queues. */