Commit d22d136b authored by Shuhei Matsumoto's avatar Shuhei Matsumoto Committed by Jim Harris
Browse files

iscsi: Move error path to the end of the function 



Moving error path to the end of the function will be easier to read.

Change-Id: I35bfd9b12d83ccb6fffe159b68dd08c87f6de0fb
Signed-off-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-on: https://review.gerrithub.io/436229


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
parent 193ecb2c

lib/iscsi/conn.c

+6 −4
Original line number Diff line number Diff line
@@ -336,10 +336,7 @@ spdk_iscsi_conn_construct(struct spdk_iscsi_portal *portal, 
	rc = spdk_iscsi_conn_params_init(&conn->params);

	if (rc < 0) {

		SPDK_ERRLOG("iscsi_conn_params_init() failed\n");

error_return:

		spdk_iscsi_param_free(conn->params);

		free_conn(conn);

		return -1;

		goto error_return;

	}

	conn->logout_timer = NULL;

	conn->shutdown_timer = NULL;
@@ -351,6 +348,11 @@ error_return: 


	spdk_iscsi_poll_group_add_conn(conn);

	return 0;



error_return:

	spdk_iscsi_param_free(conn->params);

	free_conn(conn);

	return -1;

}



void