Commit d18e6320 authored May 10, 2020 by Seth Howell Committed by Tomasz Zawadzki May 21, 2020

mk/lib: add a check that major and minor version is set for libs.



Also, while we are here, consolidate setting SO_SUFFIX to one spot.

Previously, it was possible for a library to slip through
without an SO version.

Signed-off-by: Seth Howell <seth.howell@intel.com>
Change-Id: I4db5fa5839502d266c6259892e5719b05134518c
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/2361


Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Community-CI: Broadcom CI
Reviewed-by: Paul Luse <paul.e.luse@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>

parent 2c56786e

lib/accel/Makefile

+0 −1

Original line number	Diff line number	Diff line
		@@ -36,7 +36,6 @@ include $(SPDK_ROOT_DIR)/mk/spdk.common.mk

		SO_VER := 2
		SO_MINOR := 3
		SO_SUFFIX := $(SO_VER).$(SO_MINOR)

		LIBNAME = accel
		C_SRCS = accel_engine.c

lib/bdev/Makefile

+0 −1

Original line number	Diff line number	Diff line
		@@ -36,7 +36,6 @@ include $(SPDK_ROOT_DIR)/mk/spdk.common.mk

		SO_VER := 2
		SO_MINOR := 0
		SO_SUFFIX := $(SO_VER).$(SO_MINOR)

		ifeq ($(CONFIG_VTUNE),y)
		CFLAGS += -I$(CONFIG_VTUNE_DIR)/include -I$(CONFIG_VTUNE_DIR)/sdk/src/ittnotify

lib/blob/Makefile

+0 −1

Original line number	Diff line number	Diff line
		@@ -36,7 +36,6 @@ include $(SPDK_ROOT_DIR)/mk/spdk.common.mk

		SO_VER := 3
		SO_MINOR := 0
		SO_SUFFIX := $(SO_VER).$(SO_MINOR)

		C_SRCS = blobstore.c request.c zeroes.c blob_bs_dev.c
		LIBNAME = blob

lib/blobfs/Makefile

+0 −1

Original line number	Diff line number	Diff line
		@@ -36,7 +36,6 @@ include $(SPDK_ROOT_DIR)/mk/spdk.common.mk

		SO_VER := 3
		SO_MINOR := 0
		SO_SUFFIX := $(SO_VER).$(SO_MINOR)

		C_SRCS = blobfs.c tree.c
		LIBNAME = blobfs

lib/conf/Makefile

+0 −1

Original line number	Diff line number	Diff line
		@@ -36,7 +36,6 @@ include $(SPDK_ROOT_DIR)/mk/spdk.common.mk

		SO_VER := 2
		SO_MINOR := 0
		SO_SUFFIX := $(SO_VER).$(SO_MINOR)

		C_SRCS = conf.c
		LIBNAME = conf