Commit d120447a authored by Yankun Li's avatar Yankun Li Committed by Konrad Sztyber
Browse files

lib/app: Call *_init_done if *_start_init failure 



If the tgt process fails to handle the framework_start_init request, it
should exit instead of continuing. Retrying the request will skip
subsystems that failed during the first attempt, which is not
acceptable. It’s better to shut down the tgt app.

Change-Id: I7547ddeab99263ea1f546e27eb498ea284838985
Signed-off-by: default avatarYankun Li <yankun@staff.sina.com>
Reviewed-on: https://review.spdk.io/c/spdk/spdk/+/26138


Reviewed-by: default avatarKonrad Sztyber <ksztyber@nvidia.com>
Tested-by: default avatarSPDK Automated Test System <spdkbot@gmail.com>
Reviewed-by: default avatarChangpeng Liu <changpeliu@tencent.com>
Reviewed-by: default avatarGangCao <gang.cao@intel.com>
parent 297150f3

lib/event/app.c

+2 −0
Original line number Diff line number Diff line
@@ -1508,6 +1508,8 @@ rpc_framework_start_init_cpl(int rc, void *arg1) 
		}

		spdk_jsonrpc_send_error_response(request, SPDK_JSONRPC_ERROR_INTERNAL_ERROR,

						 "framework_initialization failed");



		app_subsystem_init_done(rc, NULL);

		return;

	}