Commit d06f1c49 authored by Shuhei Matsumoto's avatar Shuhei Matsumoto Committed by Tomasz Zawadzki
Browse files

bdev: Hold mutex when adding bdev name to global bdev name tree 



We had not held mutex when adding bdev name to global bdev name tree
in bdev_name_add(). Fix these in this patch.

Signed-off-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Change-Id: I33813638f11da85263ec0c8849e566d247a45d43
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/8524


Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarZiye Yang <ziye.yang@intel.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@mellanox.com>
Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
parent 20ba4a0d

lib/bdev/bdev.c

+3 −0
Original line number Diff line number Diff line
@@ -3262,7 +3262,10 @@ bdev_name_add(struct spdk_bdev_name *bdev_name, struct spdk_bdev *bdev, const ch 


	bdev_name->bdev = bdev;



	pthread_mutex_lock(&g_bdev_mgr.mutex);

	tmp = RB_INSERT(bdev_name_tree, &g_bdev_mgr.bdev_names, bdev_name);

	pthread_mutex_unlock(&g_bdev_mgr.mutex);



	if (tmp != NULL) {

		SPDK_ERRLOG("Bdev name %s already exists\n", name);

		free(bdev_name->name);