Commit cf3ed0e1 authored Jan 26, 2021 by wanghailiangx Committed by Tomasz Zawadzki Feb 08, 2021

test/app/stub: fix a null pointer passed as argument 'H'



When val gets optarg and argument is 'H', a  null pointer passed as argument 1,
which is declared to never be null. So we adjust the order, judge 'H' first.
Then './test/app/stub/stub -H' will display help info instead of 'Segmentation fault'.
This patch fixed it.
And case 'default' should return 1.

Change-Id: I6ba9311eb5ac90266fdf33ab3424ab28fa64a78f
Signed-off-by: wanghailiangx <hailiangx.e.wang@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/6083


Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>

parent afbab54c

test/app/stub/stub.c

+3 −4

Original line number	Diff line number	Diff line
		@@ -158,9 +158,9 @@ main(int argc, char **argv)
		while ((ch = getopt(argc, argv, "i:m:n:p:s:H")) != -1) {
		if (ch == 'm') {
		opts.reactor_mask = optarg;
		} else if (ch == '?') {
		} else if (ch == '?' \|\| ch == 'H') {
		usage(argv[0]);
		exit(1);
		exit(EXIT_SUCCESS);
		} else {
		val = spdk_strtol(optarg, 10);
		if (val < 0) {
		@@ -180,10 +180,9 @@ main(int argc, char **argv)
		case 's':
		opts.mem_size = val;
		break;
		case 'H':
		default:
		usage(argv[0]);
		exit(EXIT_SUCCESS);
		exit(EXIT_FAILURE);
		}
		}
		}

Admin message