Commit cee0fef1 authored by Shuhei Matsumoto's avatar Shuhei Matsumoto Committed by Jim Harris
Browse files

perf: Fix performance degradation when the ns is formatted to use Protection Information 



Format of namespace is not changed during running but namespace
information is collected by identify command for every IO.

This caused much degradation of performance.

Hence call spdk_nvme_ns_get_data() and hold the pointer to the
buffer in which namespace information is stored  at registration
of namespace and use the pointer in both task_extended_lba_setup_pi()
and task_extended_lba_pi_verify().

Change-Id: I12461ccb763247bbb9ccbe34802805ace67d9400
Signed-off-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-on: https://review.gerrithub.io/424362


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
parent d70941c3

examples/nvme/perf/perf.c

+5 −6
Original line number Diff line number Diff line
@@ -83,6 +83,7 @@ struct ns_entry { 
	uint16_t		apptag_mask;

	uint16_t		apptag;

	char			name[1024];

	const struct spdk_nvme_ns_data	*nsdata;

};



static const double g_latency_cutoffs[] = {
@@ -267,6 +268,8 @@ register_ns(struct spdk_nvme_ctrlr *ctrlr, struct spdk_nvme_ns *ns) 
		g_max_io_size_blocks = entry->io_size_blocks;

	}



	entry->nsdata = spdk_nvme_ns_get_data(ns);



	snprintf(entry->name, 44, "%-20.20s (%-20.20s)", cdata->mn, cdata->sn);



	g_num_namespaces++;
@@ -489,7 +492,6 @@ task_extended_lba_setup_pi(struct ns_entry *entry, struct perf_task *task, uint6 
	struct spdk_nvme_protection_info *pi;

	uint32_t i, md_size, sector_size, pi_offset;

	uint16_t crc16;

	const struct spdk_nvme_ns_data *nsdata;



	task->appmask = 0;

	task->apptag = 0;
@@ -515,12 +517,11 @@ task_extended_lba_setup_pi(struct ns_entry *entry, struct perf_task *task, uint6 


	sector_size = spdk_nvme_ns_get_sector_size(entry->u.nvme.ns);

	md_size = spdk_nvme_ns_get_md_size(entry->u.nvme.ns);

	nsdata = spdk_nvme_ns_get_data(entry->u.nvme.ns);



	/* PI locates at the first 8 bytes of metadata,

	 * doesn't support now

	 */

	if (nsdata->dps.md_start) {

	if (entry->nsdata->dps.md_start) {

		return;

	}
@@ -560,7 +561,6 @@ task_extended_lba_pi_verify(struct ns_entry *entry, struct perf_task *task, 
	struct spdk_nvme_protection_info *pi;

	uint32_t i, md_size, sector_size, pi_offset, ref_tag;

	uint16_t crc16, guard, app_tag;

	const struct spdk_nvme_ns_data *nsdata;



	if (spdk_nvme_ns_get_pi_type(entry->u.nvme.ns) ==

	    SPDK_NVME_FMT_NVM_PROTECTION_DISABLE) {
@@ -569,12 +569,11 @@ task_extended_lba_pi_verify(struct ns_entry *entry, struct perf_task *task, 


	sector_size = spdk_nvme_ns_get_sector_size(entry->u.nvme.ns);

	md_size = spdk_nvme_ns_get_md_size(entry->u.nvme.ns);

	nsdata = spdk_nvme_ns_get_data(entry->u.nvme.ns);



	/* PI locates at the first 8 bytes of metadata,

	 * doesn't support now

	 */

	if (nsdata->dps.md_start) {

	if (entry->nsdata->dps.md_start) {

		return;

	}