Commit ce83fc2a authored by Seth Howell's avatar Seth Howell Committed by Tomasz Zawadzki
Browse files

lib/nvme: remove qpair from ctrl list in connect fail path 



This is an oversight that can cause issues with looping
through the list if we end up allocating the same qpair
twice.

Signed-off-by: default avatarSeth Howell <seth.howell@intel.com>
Change-Id: I513ea35398f4b724366c21be144531fbfbdb4347
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/3835


Community-CI: Mellanox Build Bot
Community-CI: Broadcom CI
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
parent ed7848f2

lib/nvme/nvme_ctrlr.c

+1 −0
Original line number Diff line number Diff line
@@ -457,6 +457,7 @@ spdk_nvme_ctrlr_alloc_io_qpair(struct spdk_nvme_ctrlr *ctrlr, 
	rc = spdk_nvme_ctrlr_connect_io_qpair(ctrlr, qpair);

	if (rc != 0) {

		SPDK_ERRLOG("nvme_transport_ctrlr_connect_io_qpair() failed\n");

		TAILQ_REMOVE(&ctrlr->active_io_qpairs, qpair, tailq);

		nvme_transport_ctrlr_delete_io_qpair(ctrlr, qpair);

		return NULL;

	}