Commit ce37c9e6 authored Jan 19, 2023 by Michal Berger Committed by Jim Harris Jan 20, 2023

test/nvmf: Verify perf's exit status



Since the perf application is run in the background the script would
not pick up its potential crash - the main condition itself was simply
checking if app is still running. Since there were occasions where
the failure was missed up until the cleanup stage, try to catch it
early on by verifying perf's exit status - hook it into NOT() as
the app is expected to fail by the test but we need to filter out
crash scenarios.

Signed-off-by: Michal Berger <michal.berger@intel.com>
Change-Id: I9a9304616c0a4dba42467f65c1a2c770352f08ea
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16345


Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>

parent 52c86e21

test/nvmf/target/delete_subsystem.sh

+6 −0

Original line number	Diff line number	Diff line
		@@ -41,6 +41,9 @@ while kill -0 $perf_pid; do
		fi
		done

		# Verify perf's exit status to make sure we catch a potential crash
		NOT wait "$perf_pid"

		#check that traffic goes when a new subsystem is created
		$rpc_py nvmf_create_subsystem nqn.2016-06.io.spdk:cnode1 -a -s SPDK00000000000001 -m 10
		$rpc_py nvmf_subsystem_add_listener nqn.2016-06.io.spdk:cnode1 -t $TEST_TRANSPORT -a $NVMF_FIRST_TARGET_IP -s $NVMF_PORT
		@@ -60,6 +63,9 @@ while kill -0 $perf_pid; do
		fi
		done

		# Verify perf's exit status to make sure we catch a potential crash
		wait "$perf_pid"

		trap - SIGINT SIGTERM EXIT

		nvmftestfini

Admin message