Commit cd79f1a2 authored by Jaroslaw Chachulski's avatar Jaroslaw Chachulski Committed by Tomasz Zawadzki
Browse files

scripts/rpc: remove default value from bdev_ocf_create 



Removing default options from parser command to prevent overwrite by
argparse the defaults defined in the .c files.

Signed-off-by: default avatarJaroslaw Chachulski <jaroslawx.chachulski@intel.com>
Change-Id: I9c1ba26e2b867b91fd5f7cd91edbff1844f08c79
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/12979


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarKarol Latecki <karol.latecki@intel.com>
parent ba81cb16

python/spdk/rpc/bdev.py

+3 −1
Original line number Diff line number Diff line
@@ -141,11 +141,13 @@ def bdev_ocf_create(client, name, mode, cache_line_size, cache_bdev_name, core_b 
    params = {

        'name': name,

        'mode': mode,

        'cache_line_size': cache_line_size,

        'cache_bdev_name': cache_bdev_name,

        'core_bdev_name': core_bdev_name,

    }



    if cache_line_size:

        params['cache_line_size'] = cache_line_size



    return client.call('bdev_ocf_create', params)

scripts/rpc.py

+1 −2
Original line number Diff line number Diff line
@@ -291,8 +291,7 @@ if __name__ == "__main__": 
        help='OCF cache line size. The unit is KiB',

        type=int,

        choices=[4, 8, 16, 32, 64],

        required=False,

        default=0,

        required=False

    )

    p.add_argument('cache_bdev_name', help='Name of underlying cache bdev')

    p.add_argument('core_bdev_name', help='Name of underlying core bdev')