Commit ca5ce67f authored by Alexey Marchuk's avatar Alexey Marchuk Committed by Tomasz Zawadzki
Browse files

nvme/rdma: Ignore completion when we can't find qpair 



When poll_group is used, several qpairs share the same CQ
and it is possible to receive a completion with error (e.g.
IBV_WC_WR_FLUSH_ERR) for already disconnected qpair
That happens due to qpair is destroyed while there are
submitted but not completed send/receive Work Requests

To avoid such situation, we should not detroy ibv
qpair until we reap completions for all submitted
send/receive work requests. That requires some
rework in rdma transport and will be implemented
later

Signed-off-by: default avatarAlexey Marchuk <alexeymar@mellanox.com>
Change-Id: Idb6213d45c2a7954b9ab280f5eb5e021be00505f
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/9056


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
parent 00277bc5

lib/nvme/nvme_rdma.c

+9 −1
Original line number Diff line number Diff line
@@ -2240,7 +2240,15 @@ nvme_rdma_cq_process_completions(struct ibv_cq *cq, uint32_t batch_size, 
					rqpair = rdma_qpair != NULL ? rdma_qpair : nvme_rdma_poll_group_get_qpair_by_id(group,

							wc[i].qp_num);

				}

				assert(rqpair);

				if (!rqpair) {

					/* When poll_group is used, several qpairs share the same CQ and it is possible to

					 * receive a completion with error (e.g. IBV_WC_WR_FLUSH_ERR) for already disconnected qpair

					 * That happens due to qpair is destroyed while there are submitted but not completed send/receive

					 * Work Requests

					 * TODO: ibv qpair must be destroyed only when all submitted Work Requests are completed */

					assert(group);

					continue;

				}

				assert(rqpair->current_num_sends > 0);

				rqpair->current_num_sends--;

				nvme_rdma_conditional_fail_qpair(rqpair, group);