Commit c9d84215 authored by Zhiqiang Liu's avatar Zhiqiang Liu Committed by Tomasz Zawadzki
Browse files

spdk_top:check return value of strdup in store_last_run_counter() 



In store_last_run_counter(), history->poller_name is set to
strdup(), which may return NULL. We should deal with it.

Signed-off-by: default avatarZhiqiang Liu <liuzhiqiang26@huawei.com>
Change-Id: Ice5f27c4a7d2f9abd528b97a48ff5f92b48c8d7c
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/8306


Community-CI: Mellanox Build Bot
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@mellanox.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
parent 2ef4855e

app/spdk_top/spdk_top.c

+5 −0
Original line number Diff line number Diff line
@@ -612,6 +612,11 @@ store_last_run_counter(const char *poller_name, uint64_t thread_id, uint64_t las 
		return;

	}

	history->poller_name = strdup(poller_name);

	if (!history->poller_name) {

		fprintf(stderr, "Unable to allocate poller_name of a history object in store_last_run_counter.\n");

		free(history);

		return;

	}

	history->thread_id = thread_id;

	history->last_run_counter = last_run_counter;