Commit c9c57691 authored by Pawel Kaminski's avatar Pawel Kaminski Committed by Jim Harris
Browse files

test: Shellcheck - move rule SC2162 to exception list 



read without -r will mangle backslashes

Change-Id: I9eb59dce40c0bfb59d865319992b419d512dc41b
Signed-off-by: default avatarPawel Kaminski <pawelx.kaminski@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/471885


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
parent 933d990e

scripts/check_format.sh

+1 −2
Original line number Diff line number Diff line
@@ -243,8 +243,7 @@ if hash shellcheck 2>/dev/null; then 
	SHCK_EXCLUDE="SC1083,SC2002,\

SC2010,SC2012,SC2016,SC2034,SC2045,SC2046,SC2068,SC2086,SC2089,SC2090,\

SC2097,SC2098,SC2119,SC2120,SC2128,\

SC2129,SC2140,SC2142,SC2143,SC2154,SC2155,\

SC2162"

SC2129,SC2140,SC2142,SC2143,SC2154,SC2155"

	# SPDK fails some error checks which have been deprecated in later versions of shellcheck.

	# We will not try to fix these error checks, but instead just leave the error types here

	# so that we can still run with older versions of shellcheck.

test/ftl/ftl.sh

+1 −1
Original line number Diff line number Diff line
@@ -12,7 +12,7 @@ function at_ftl_exit() { 
	PCI_WHITELIST="$device" PCI_BLACKLIST="" DRIVER_OVERRIDE="$ocssd_original_dirver" ./scripts/setup.sh

}



read device _ <<< "$OCSSD_PCI_DEVICES"

read -r device _ <<< "$OCSSD_PCI_DEVICES"



if [[ -z "$device" ]]; then

	echo "OCSSD device list is empty."

test/json_config/json_config.sh

+1 −1
Original line number Diff line number Diff line
@@ -62,7 +62,7 @@ function tgt_check_notifications() { 
        local event_line event ev_type ev_ctx

        local rc=""



        while read event_line; do

        while read -r event_line; do

                # remove ID

                event="${event_line%:*}"

test/vhost/common.sh

+1 −1
Original line number Diff line number Diff line
@@ -32,7 +32,7 @@ function vhosttestinit() 
		if [[ ! -f $VM_IMAGE ]]; then

			echo "VM image not found at $VM_IMAGE"

			echo "Download to $HOME? [yn]"

			read download

			read -r download

			if [ "$download" = "y" ]; then

				curl https://dqtibwqq6s6ux.cloudfront.net/download/test_resources/vhost_vm_image.tar.gz | tar xz -C $HOME

			fi

test/vhost/fiotest/fio.sh

+1 −1
Original line number Diff line number Diff line
@@ -206,7 +206,7 @@ for vm_num in $used_vms; do 
done



if $dry_run; then

	read -p "Enter to kill evething" xx

	read -r -p "Enter to kill evething" xx

	sleep 3

	at_app_exit

	exit 0