Commit c9b46ba9 authored by Michal Berger's avatar Michal Berger Committed by Jim Harris
Browse files

pkgdep/git: Don't install sources in parallel 



As stated in a66c52fd this is racy and also masks out all potential
failures since wait() will not indicate if all processes succeded
or failed, it will return only with exit status from the last
process it handled.

Change-Id: I9e2b5d01ac8f951082e0b28eeae5455ecd0c8e74
Signed-off-by: default avatarMichal Berger <michalx.berger@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/4680


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
parent 721344d7

test/common/config/pkgdep/git

+1 −2
Original line number Diff line number Diff line
@@ -367,10 +367,9 @@ sudo mkdir -p "$GIT_REPOS" 
for source in "${sources[@]}"; do

	source_conf=${source^^}

	if [[ ${!source_conf} == true ]]; then

		"$source" &

		"$source"

	fi

done

wait



if [[ $INSTALL_REFSPDK == true ]]; then

	# Serialize builds as refspdk depends on spdk