Commit c97e5645 authored by yidong0635's avatar yidong0635 Committed by Jim Harris
Browse files

bdev/nvme: fix issue about coredump which caused by assert error. 



 Here assert(nvme_bdev->id == nsid) ,there's inactive case about nvme_bdev,
 that code will continue. So need to skip the same case in remove_cb.

Change-Id: Idd3bd16d32e75f6d0e448b838676eb6f2ca5cfad
Signed-off-by: default avataryidong0635 <dongx.yi@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/451445


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarDarek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
parent bb488d28

lib/bdev/nvme/bdev_nvme.c

+1 −1
Original line number Diff line number Diff line
@@ -1037,8 +1037,8 @@ remove_cb(void *cb_ctx, struct spdk_nvme_ctrlr *ctrlr) 
				uint32_t	nsid = i + 1;



				nvme_bdev = &nvme_bdev_ctrlr->bdevs[nsid - 1];

				assert(nvme_bdev->id == nsid);

				if (nvme_bdev->active) {

					assert(nvme_bdev->id == nsid);

					spdk_bdev_unregister(&nvme_bdev->disk, NULL, NULL);

				}

			}