Commit c9224e26 authored by Shuhei Matsumoto's avatar Shuhei Matsumoto Committed by Tomasz Zawadzki
Browse files

bdev/raid: Handle resize event from a base_bdev 



Signed-off-by: default avatarShuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: Id22973cf7ce49e8bbfec16c4518dfd3a7033c61a
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16259


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: default avatarArtur Paszkiewicz <artur.paszkiewicz@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
parent eb5789ce

module/bdev/raid/bdev_raid.c

+39 −1
Original line number Diff line number Diff line
@@ -1220,7 +1220,7 @@ raid_bdev_find_by_base_bdev(struct spdk_bdev *base_bdev, struct raid_bdev **_rai 
 * is removed. This function checks if this base bdev is part of any raid bdev

 * or not. If yes, it takes necessary action on that particular raid bdev.

 * params:

 * base_bdev - pointer to base bdev pointer which got removed

 * base_bdev - pointer to base bdev which got removed

 * returns:

 * none

 */
@@ -1259,6 +1259,40 @@ raid_bdev_remove_base_bdev(struct spdk_bdev *base_bdev) 
	raid_bdev_deconfigure(raid_bdev, NULL, NULL);

}



/*

 * brief:

 * raid_bdev_resize_base_bdev function is called by below layers when base_bdev

 * is resized. This function checks if the smallest size of the base_bdevs is changed.

 * If yes, call module handler to resize the raid_bdev if implemented.

 * params:

 * base_bdev - pointer to base bdev which got resized.

 * returns:

 * none

 */

static void

raid_bdev_resize_base_bdev(struct spdk_bdev *base_bdev)

{

	struct raid_bdev	*raid_bdev = NULL;

	struct raid_base_bdev_info *base_info;



	SPDK_DEBUGLOG(bdev_raid, "raid_bdev_resize_base_bdev\n");



	/* Find the raid_bdev which has claimed this base_bdev */

	if (!raid_bdev_find_by_base_bdev(base_bdev, &raid_bdev, &base_info)) {

		SPDK_ERRLOG("raid_bdev whose base_bdev '%s' not found\n", base_bdev->name);

		return;

	}



	assert(spdk_get_thread() == spdk_thread_get_app_thread());



	SPDK_NOTICELOG("base_bdev '%s' was resized: old size %" PRIu64 ", new size %" PRIu64 "\n",

		       base_bdev->name, base_info->blockcnt, base_bdev->blockcnt);



	if (raid_bdev->module->resize) {

		raid_bdev->module->resize(raid_bdev);

	}

}



/*

 * brief:

 * raid_bdev_event_base_bdev function is called by below layers when base_bdev
@@ -1278,6 +1312,9 @@ raid_bdev_event_base_bdev(enum spdk_bdev_event_type type, struct spdk_bdev *bdev 
	case SPDK_BDEV_EVENT_REMOVE:

		raid_bdev_remove_base_bdev(bdev);

		break;

	case SPDK_BDEV_EVENT_RESIZE:

		raid_bdev_resize_base_bdev(bdev);

		break;

	default:

		SPDK_NOTICELOG("Unsupported bdev event: type %d\n", type);

		break;
@@ -1367,6 +1404,7 @@ raid_bdev_configure_base_bdev(struct raid_bdev *raid_bdev, struct raid_base_bdev 


	base_info->bdev = bdev;

	base_info->desc = desc;

	base_info->blockcnt = bdev->blockcnt;

	raid_bdev->num_base_bdevs_discovered++;

	assert(raid_bdev->num_base_bdevs_discovered <= raid_bdev->num_base_bdevs);

module/bdev/raid/bdev_raid.h

+9 −0
Original line number Diff line number Diff line
@@ -61,6 +61,9 @@ struct raid_base_bdev_info { 
	 * descriptor will be closed

	 */

	bool			remove_scheduled;



	/* Hold the number of blocks to know how large the base bdev is resized. */

	uint64_t		blockcnt;

};



/*
@@ -228,6 +231,12 @@ struct raid_bdev_module { 
	 */

	struct spdk_io_channel *(*get_io_channel)(struct raid_bdev *raid_bdev);



	/*

	 * Called when a base_bdev is resized to resize the raid if the condition

	 * is satisfied.

	 */

	void (*resize)(struct raid_bdev *raid_bdev);



	TAILQ_ENTRY(raid_bdev_module) link;

};