Commit c85360da authored by Daniel Verkamp's avatar Daniel Verkamp
Browse files

build: warn about old-style C function definitions 



Fix the existing cases (all missing void in parameter lists) and enable
the warning to prevent new ones from being introduced.

Change-Id: Ieaf00b3dfd5daf1e21fcbefb124514882e8996c9
Signed-off-by: default avatarDaniel Verkamp <daniel.verkamp@intel.com>
parent db8b791f

lib/bdev/malloc/blockdev_malloc.c

+2 −2
Original line number Diff line number Diff line
@@ -343,7 +343,7 @@ static void free_malloc_disk(struct malloc_disk *mdisk) 
	rte_free(mdisk);

}



static int blockdev_malloc_initialize()

static int blockdev_malloc_initialize(void)

{

	struct spdk_conf_section *sp = spdk_conf_find_section(NULL, "Malloc");

	int NumberOfLuns, LunSizeInMB, BlockSize, i;
@@ -374,7 +374,7 @@ static int blockdev_malloc_initialize() 
	return 0;

}



static void blockdev_malloc_finish()

static void blockdev_malloc_finish(void)

{

	struct malloc_disk *mdisk;

mk/spdk.common.mk

+1 −1
Original line number Diff line number Diff line
@@ -97,7 +97,7 @@ ifeq ($(CONFIG_PCIACCESS), y) 
PCIACCESS_LIB=-lpciaccess

endif



CFLAGS   += $(COMMON_CFLAGS) -Wno-pointer-sign -Wstrict-prototypes -std=gnu99

CFLAGS   += $(COMMON_CFLAGS) -Wno-pointer-sign -Wstrict-prototypes -Wold-style-definition -std=gnu99

CXXFLAGS += $(COMMON_CFLAGS) -std=c++0x



ifeq ($(CONFIG_ADDRESS_SANITIZER),y)