Commit c623bf39 authored Jan 18, 2024 by Artur Paszkiewicz Committed by Tomasz Zawadzki Jan 19, 2024

nvmf: fix setting ptpl for SPDK_NVME_GLOBAL_NS_TAG



The first ns without ptpl_file would break the loop.

Reported-by: Jim Harris <jim.harris@samsung.com>
Change-Id: I9fd9dc041a4e0dd1a44c7dd409d1308cf71c1329
Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21486


Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

parent 549d907b

lib/nvmf/ctrlr.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -1836,10 +1836,12 @@ nvmf_ctrlr_set_features_reservation_persistence(struct spdk_nvmf_request *req)
		if (cmd->nsid != SPDK_NVME_GLOBAL_NS_TAG && ns && ns->ptpl_file) {
		ns->ptpl_activated = ptpl;
		} else if (cmd->nsid == SPDK_NVME_GLOBAL_NS_TAG) {
		for (ns = spdk_nvmf_subsystem_get_first_ns(ctrlr->subsys); ns && ns->ptpl_file;
		for (ns = spdk_nvmf_subsystem_get_first_ns(ctrlr->subsys); ns;
		ns = spdk_nvmf_subsystem_get_next_ns(ctrlr->subsys, ns)) {
		if (ns->ptpl_file) {
		ns->ptpl_activated = ptpl;
		}
		}
		} else {
		SPDK_ERRLOG("Set Features - Invalid Namespace ID or Reservation Configuration\n");
		response->status.sct = SPDK_NVME_SCT_GENERIC;