Commit c4bda88b authored by Wojciech Malikowski's avatar Wojciech Malikowski Committed by Tomasz Zawadzki
Browse files

lib/ftl: Change ftl_wptr_ready() return value from int to bool 



ftl_wptr_ready() return value is true or false so
it should return bool instead int.

Change-Id: I653e4ee1271d54f2e8c7b6fa0144a468faec4607
Signed-off-by: default avatarWojciech Malikowski <wojciech.malikowski@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/555


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
parent 149511c1

lib/ftl/ftl_core.c

+6 −6
Original line number Diff line number Diff line
@@ -652,7 +652,7 @@ ftl_wptr_user_blocks_left(const struct ftl_wptr *wptr) 
	return ftl_band_user_blocks_left(wptr->band, wptr->offset);

}



static int

static bool

ftl_wptr_ready(struct ftl_wptr *wptr)

{

	struct ftl_band *band = wptr->band;
@@ -664,14 +664,14 @@ ftl_wptr_ready(struct ftl_wptr *wptr) 
		if (spdk_unlikely(wptr->zone->info.state == SPDK_BDEV_ZONE_STATE_OFFLINE)) {

			ftl_wptr_advance(wptr, wptr->dev->xfer_size);

		}

		return 0;

		return false;

	}



	/* If we're in the process of writing metadata, wait till it is */

	/* completed. */

	/* TODO: we should probably change bands once we're writing tail md */

	if (ftl_band_state_changing(band)) {

		return 0;

		return false;

	}



	if (band->state == FTL_BAND_STATE_FULL) {
@@ -682,7 +682,7 @@ ftl_wptr_ready(struct ftl_wptr *wptr) 
			}

		}



		return 0;

		return false;

	}



	if (band->state != FTL_BAND_STATE_OPEN) {
@@ -691,10 +691,10 @@ ftl_wptr_ready(struct ftl_wptr *wptr) 
			assert(false);

		}



		return 0;

		return false;

	}



	return 1;

	return true;

}



int