Commit c41eb0a2 authored by Konrad Sztyber's avatar Konrad Sztyber Committed by Tomasz Zawadzki
Browse files

memory: remove outdated comment in spdk_vtophys() 



We don't do any bitwise-or operations in this function, so that comment
was only misleading.  And checking for errors before interpreting the
result of a function is standard, so there's little reason to explain it
here.

Change-Id: I85a89a63ff2aa6b6470ef72155436341f1aa3917
Signed-off-by: default avatarKonrad Sztyber <ksztyber@nvidia.com>
Reviewed-on: https://review.spdk.io/c/spdk/spdk/+/26219


Tested-by: default avatarSPDK Automated Test System <spdkbot@gmail.com>
Community-CI: Mellanox Build Bot
Reviewed-by: default avatarBen Walker <ben@nvidia.com>
Reviewed-by: default avatarJim Harris <jim.harris@nvidia.com>
parent eba1bac6

lib/env_dpdk/memory.c

+0 −8
Original line number Diff line number Diff line
@@ -1853,14 +1853,6 @@ spdk_vtophys(const void *buf, uint64_t *size) 


	vaddr = (uint64_t)buf;

	paddr_2mb = spdk_mem_map_translate(g_vtophys_map, vaddr, size);



	/*

	 * SPDK_VTOPHYS_ERROR has all bits set, so if the lookup returned SPDK_VTOPHYS_ERROR,

	 * we will still bitwise-or it with the buf offset below, but the result will still be

	 * SPDK_VTOPHYS_ERROR. However now that we do + rather than | (due to PCI vtophys being

	 * unaligned) we must now check the return value before addition.

	 */

	SPDK_STATIC_ASSERT(SPDK_VTOPHYS_ERROR == UINT64_C(-1), "SPDK_VTOPHYS_ERROR should be all 1s");

	if (paddr_2mb == SPDK_VTOPHYS_ERROR) {

		return SPDK_VTOPHYS_ERROR;

	} else {