Commit c3e0eb45 authored Feb 06, 2020 by Tomasz Kulasek Committed by Tomasz Zawadzki Feb 10, 2020

nvme/rpc: fix memory leak when cmdbuf decode fails for bdev_nvme_send_cmd



Change-Id: I265f7b87d85c99f1fd709418b575c500a686e093
Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/622


Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>

parent 83086b59

module/bdev/nvme/nvme_rpc.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -280,10 +280,12 @@ rpc_decode_cmdbuf(const struct spdk_json_val val, void out)

		rc = spdk_base64_urlsafe_decode(cmdbuf, &raw_len, text);
		if (rc) {
		free(cmdbuf);
		goto out;
		}
		if (raw_len != sizeof(*cmdbuf)) {
		rc = -EINVAL;
		free(cmdbuf);
		goto out;
		}