Commit c1e0bded authored by Seth Howell's avatar Seth Howell Committed by Ben Walker
Browse files

nvmf_tgt: read ret from spdk_nvmf_poll_group_add. 



It is possible for spdk_nvmf_poll_group_add to fail. In this case we
need to tear down the qpair in the same way that we do in the new_qpair
function.

Change-Id: I17abdec2646d2b7f9ed07c9b9b3e74d3d0991903
Signed-off-by: default avatarSeth Howell <seth.howell@intel.com>
Reviewed-on: https://review.gerrithub.io/c/443472


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
parent 14548576

lib/event/subsystems/nvmf/nvmf_tgt.c

+4 −1
Original line number Diff line number Diff line
@@ -119,7 +119,10 @@ nvmf_tgt_poll_group_add(void *arg1, void *arg2) 
	struct spdk_nvmf_qpair *qpair = arg1;

	struct nvmf_tgt_poll_group *pg = arg2;



	spdk_nvmf_poll_group_add(pg->group, qpair);

	if (spdk_nvmf_poll_group_add(pg->group, qpair) != 0) {

		SPDK_ERRLOG("Unable to add the qpair to a poll group.\n");

		spdk_nvmf_qpair_disconnect(qpair, NULL, NULL);

	}

}



/* Round robin selection of cores */