Commit c161969d authored by Jim Harris's avatar Jim Harris Committed by Konrad Sztyber
Browse files

bdev/iscsi: fix use-after-free in bdev_iscsi_command_cb() 



Fixes issue #2946.

Signed-off-by: default avatarJim Harris <james.r.harris@intel.com>
Change-Id: Ibd4d68ae6c639aede1fab56d04adf5583ef347f5
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/17210


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
parent 0bd1ca9d

module/bdev/iscsi/bdev_iscsi.c

+2 −2
Original line number Diff line number Diff line
@@ -269,8 +269,6 @@ bdev_iscsi_command_cb(struct iscsi_context *context, int status, void *_task, vo 
	iscsi_io->asc = (task->sense.ascq >> 8) & 0xFF;

	iscsi_io->ascq = task->sense.ascq & 0xFF;



	scsi_free_scsi_task(task);



	if (_bdev_iscsi_is_size_change(status, task)) {

		bdev_iscsi_readcapacity16(context, iscsi_io->lun);
@@ -285,6 +283,8 @@ bdev_iscsi_command_cb(struct iscsi_context *context, int status, void *_task, vo 
	} else {

		bdev_iscsi_io_complete(iscsi_io, SPDK_BDEV_IO_STATUS_SUCCESS);

	}



	scsi_free_scsi_task(task);

}



static int