Commit c138dfd3 authored by Changpeng Liu's avatar Changpeng Liu Committed by Jim Harris
Browse files

nvmf/vfio-user: don't allocate internal data buffers for vfio-user target 



Change-Id: I75f1f1a493a480aadbc233b4583616886559565c
Signed-off-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/8474


Community-CI: Mellanox Build Bot
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatar <dongx.yi@intel.com>
Reviewed-by: default avatarJohn Levon <levon@movementarian.org>
parent 563f69eb

lib/nvmf/transport.c

+13 −12
Original line number Diff line number Diff line
@@ -201,6 +201,7 @@ spdk_nvmf_transport_create(const char *transport_name, struct spdk_nvmf_transpor 
		return NULL;

	}



	if (opts_local.num_shared_buffers) {

		transport->data_buf_pool = spdk_mempool_create(spdk_mempool_name,

					   opts_local.num_shared_buffers,

					   opts_local.io_unit_size + NVMF_DATA_BUFFER_ALIGNMENT,
@@ -212,6 +213,7 @@ spdk_nvmf_transport_create(const char *transport_name, struct spdk_nvmf_transpor 
			ops->destroy(transport, NULL, NULL);

			return NULL;

		}

	}



	return transport;

}
@@ -239,9 +241,8 @@ spdk_nvmf_transport_destroy(struct spdk_nvmf_transport *transport, 
				    spdk_mempool_count(transport->data_buf_pool),

				    transport->opts.num_shared_buffers);

		}

	}



		spdk_mempool_free(transport->data_buf_pool);

	}



	return transport->ops->destroy(transport, cb_fn, cb_arg);

}

lib/nvmf/vfio_user.c

+1 −1
Original line number Diff line number Diff line
@@ -57,7 +57,7 @@ 
#define NVMF_VFIO_USER_DEFAULT_IN_CAPSULE_DATA_SIZE 0

#define NVMF_VFIO_USER_DEFAULT_MAX_IO_SIZE ((NVMF_REQ_MAX_BUFFERS - 1) << SHIFT_4KB)

#define NVMF_VFIO_USER_DEFAULT_IO_UNIT_SIZE NVMF_VFIO_USER_DEFAULT_MAX_IO_SIZE

#define NVMF_VFIO_USER_DEFAULT_NUM_SHARED_BUFFERS 512 /* internal buf size */

#define NVMF_VFIO_USER_DEFAULT_NUM_SHARED_BUFFERS 0 /* internal buf size */

#define NVMF_VFIO_USER_DEFAULT_BUFFER_CACHE_SIZE 0



#define NVMF_VFIO_USER_DOORBELLS_OFFSET	0x1000