Commit c0babf53 authored by Michael Piszczek's avatar Michael Piszczek Committed by Tomasz Zawadzki
Browse files

spdk_top: Remove double sorting when getting poller data 



No longer need the extra double sort the poller data since the
data is now always double sorted.

Signed-off-by: default avatarMichael Piszczek <mpiszczek@ddn.com>
Change-Id: Ic2edf92ec4374c3fb1c2a3ad8d2ba7c111e2e481
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/10107


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarKrzysztof Karas <krzysztof.karas@intel.com>
parent f0a663a9

app/spdk_top/spdk_top.c

+2 −12
Original line number Diff line number Diff line
@@ -851,11 +851,7 @@ subsort_pollers(enum column_pollers_type sort_column, const void *p1, const void 
}



static int

#ifdef __FreeBSD__

sort_pollers(void *arg, const void *p1, const void *p2)

#else

sort_pollers(const void *p1, const void *p2, void *arg)

#endif

sort_pollers(const void *p1, const void *p2)

{

	int rc;
@@ -874,7 +870,6 @@ get_pollers_data(void) 
	uint64_t i = 0;

	uint32_t current_pollers_count;

	struct rpc_poller_info pollers_info[RPC_MAX_POLLERS];

	enum column_pollers_type column_sort;



	rc = rpc_send_req("thread_get_pollers", &json_resp);

	if (rc) {
@@ -906,12 +901,7 @@ get_pollers_data(void) 


	g_last_pollers_count = current_pollers_count;



	column_sort = COL_POLLERS_NAME;

	qsort_r(&pollers_info, g_last_pollers_count, sizeof(struct rpc_poller_info), sort_pollers,

		(void *)&column_sort);

	column_sort = g_current_sort_col[POLLERS_TAB];

	qsort_r(&pollers_info, g_last_pollers_count, sizeof(struct rpc_poller_info), sort_pollers,

		(void *)&column_sort);

	qsort(&pollers_info, g_last_pollers_count, sizeof(struct rpc_poller_info), sort_pollers);



	memcpy(&g_pollers_info, &pollers_info, sizeof(struct rpc_poller_info) * g_last_pollers_count);