Commit c00eb482 authored by Yankun Li's avatar Yankun Li Committed by Tomasz Zawadzki
Browse files

bdev/raid: check whether base bdev name is empty 



When creating raid bdev, if there are more than one
space between base bdev, the empty string base bdev
will appear

Change-Id: I1b82ded7251419603205865782816aab4eff0681
Signed-off-by: default avatarYankun Li <845245370@qq.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22379


Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: default avatarJim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarArtur Paszkiewicz <artur.paszkiewicz@intel.com>
parent 6c23277d

module/bdev/raid/bdev_raid_rpc.c

+9 −0
Original line number Diff line number Diff line
@@ -278,6 +278,15 @@ rpc_bdev_raid_create(struct spdk_jsonrpc_request *request, 
	}

	num_base_bdevs = req->base_bdevs.num_base_bdevs;



	for (i = 0; i < num_base_bdevs; i++) {

		if (strlen(req->base_bdevs.base_bdevs[i]) == 0) {

			spdk_jsonrpc_send_error_response_fmt(request, -EINVAL,

							     "The base bdev name cannot be empty: %s",

							     spdk_strerror(EINVAL));

			goto cleanup;

		}

	}



	rc = raid_bdev_create(req->name, req->strip_size_kb, num_base_bdevs,

			      req->level, req->superblock_enabled, &req->uuid, &raid_bdev);

	if (rc != 0) {

scripts/rpc.py

+1 −1
Original line number Diff line number Diff line
@@ -2159,7 +2159,7 @@ Format: 'user:u1 secret:s1 muser:mu1 msecret:ms1,user:u2 secret:s2 muser:mu2 mse 


    def bdev_raid_create(args):

        base_bdevs = []

        for u in args.base_bdevs.strip().split(" "):

        for u in args.base_bdevs.strip().split():

            base_bdevs.append(u)



        rpc.bdev.bdev_raid_create(args.client,