Commit beff2ded authored by Shuhei Matsumoto's avatar Shuhei Matsumoto Committed by Tomasz Zawadzki
Browse files

dif: Update spdk_dif_error structure to bump SO_VER forcefully



We will match enum spdk_dif_pi_format with the NVMe specification.

enum spdk_dif_pi_format was added a year ago. we need users to recompile
their application if they use enum spdk_dif_pi_format.

However, enum spdk_dif_pi_format was not used in any data structure and
ABIDIFF tool could not detect the change.

The change breaks ABI. Hence, we should bump SO_VER of lib/util in any
other way to notify the change to users.

The cleanest way to do that without hacking check_so_deps.sh is to add
a reserved field to spdk_dif_error structure.

Signed-off-by: default avatarShuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: I7e12094bbe33f6c75780f09eb58d673d75752781
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24182


Reviewed-by: default avatarAleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Mellanox Build Bot
Reviewed-by: default avatarBen Walker <ben@nvidia.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarJim Harris <jim.harris@samsung.com>
parent e8a22bcc
Loading
Loading
Loading
Loading
+2 −0
Original line number Diff line number Diff line
@@ -122,6 +122,8 @@ struct spdk_dif_error {
	/** Error type */
	uint8_t		err_type;

	uint8_t		rsvd[7];

	/** Expected value */
	uint64_t	expected;

+2 −2
Original line number Diff line number Diff line
@@ -7,8 +7,8 @@
SPDK_ROOT_DIR := $(abspath $(CURDIR)/../..)
include $(SPDK_ROOT_DIR)/mk/spdk.common.mk

SO_VER := 15
SO_MINOR := 1
SO_VER := 16
SO_MINOR := 0
SO_SUFFIX := $(SO_VER).$(SO_MINOR)

LIBNAME = accel
+2 −2
Original line number Diff line number Diff line
@@ -6,8 +6,8 @@
SPDK_ROOT_DIR := $(abspath $(CURDIR)/../..)
include $(SPDK_ROOT_DIR)/mk/spdk.common.mk

SO_VER := 9
SO_MINOR := 1
SO_VER := 10
SO_MINOR := 0

C_SRCS = base64.c bit_array.c cpuset.c crc16.c crc32.c crc32c.c crc32_ieee.c crc64.c \
	 dif.c fd.c file.c hexlify.c iov.c math.c pipe.c strerror_tls.c string.c uuid.c \