Commit be0eef0a authored by Daniel Verkamp's avatar Daniel Verkamp
Browse files

nvmf: check for missing NQN in conf parsing 



Avoid dereferencing a NULL pointer if NQN wasn't specified in the
configuration file.

Change-Id: Ie43111fce2c5fcf06bad00af10413a665dfbc45f
Signed-off-by: default avatarDaniel Verkamp <daniel.verkamp@intel.com>
Reviewed-on: https://review.gerrithub.io/407484


Tested-by: default avatarSPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
parent 6820d312

lib/event/subsystems/nvmf/conf.c

+5 −0
Original line number Diff line number Diff line
@@ -151,6 +151,11 @@ spdk_nvmf_parse_subsystem(struct spdk_conf_section *sp) 
	int num_ns;



	nqn = spdk_conf_section_get_val(sp, "NQN");

	if (nqn == NULL) {

		SPDK_ERRLOG("Subsystem missing NQN\n");

		return -1;

	}



	mode = spdk_conf_section_get_val(sp, "Mode");

	lcore = spdk_conf_section_get_intval(sp, "Core");

	num_ns = spdk_conf_section_get_intval(sp, "MaxNamespaces");