Commit bc3dfe30 authored by Shuhei Matsumoto's avatar Shuhei Matsumoto Committed by Changpeng Liu
Browse files

bdev: Fix the second parameter `success` of spdk_bdev_io_completion_cb 



The type of the second parameter `success' of spdk_bdev_io_completion_cb
is bool. Hence change the code to use bool type success or failure.

Change-Id: I9e93f4ccbb085e8e184f209e706915dcd34aa966
Signed-off-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-on: https://review.gerrithub.io/426648


Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com>
parent 1bc3837c

lib/bdev/bdev.c

+6 −7
Original line number Diff line number Diff line
@@ -1171,8 +1171,7 @@ _spdk_bdev_io_split_with_payload(void *_bdev_io) 
		if (child_iovcnt == BDEV_IO_NUM_CHILD_IOV && to_next_boundary_bytes > 0) {

			/* We've run out of child iovs - we need to fail this I/O. */

			bdev_io->internal.status = SPDK_BDEV_IO_STATUS_FAILED;

			bdev_io->internal.cb(bdev_io, SPDK_BDEV_IO_STATUS_FAILED,

					     bdev_io->internal.caller_ctx);

			bdev_io->internal.cb(bdev_io, false, bdev_io->internal.caller_ctx);

			return;

		}

	}
@@ -1211,13 +1210,13 @@ _spdk_bdev_io_split_done(struct spdk_bdev_io *bdev_io, bool success, void *cb_ar 


	if (!success) {

		parent_io->internal.status = SPDK_BDEV_IO_STATUS_FAILED;

		parent_io->internal.cb(parent_io, SPDK_BDEV_IO_STATUS_FAILED, parent_io->internal.caller_ctx);

		parent_io->internal.cb(parent_io, false, parent_io->internal.caller_ctx);

		return;

	}



	if (parent_io->u.bdev.split_remaining_num_blocks == 0) {

		parent_io->internal.status = SPDK_BDEV_IO_STATUS_SUCCESS;

		parent_io->internal.cb(parent_io, SPDK_BDEV_IO_STATUS_SUCCESS, parent_io->internal.caller_ctx);

		parent_io->internal.cb(parent_io, true, parent_io->internal.caller_ctx);

		return;

	}
@@ -3466,7 +3465,7 @@ _spdk_bdev_write_zero_buffer_next(void *_bdev_io) 
		/* This should never happen. */

		assert(false);

		bdev_io->internal.status = SPDK_BDEV_IO_STATUS_FAILED;

		bdev_io->internal.cb(bdev_io, SPDK_BDEV_IO_STATUS_FAILED, bdev_io->internal.caller_ctx);

		bdev_io->internal.cb(bdev_io, false, bdev_io->internal.caller_ctx);

	}

}
@@ -3479,13 +3478,13 @@ _spdk_bdev_write_zero_buffer_done(struct spdk_bdev_io *bdev_io, bool success, vo 


	if (!success) {

		parent_io->internal.status = SPDK_BDEV_IO_STATUS_FAILED;

		parent_io->internal.cb(parent_io, SPDK_BDEV_IO_STATUS_FAILED, parent_io->internal.caller_ctx);

		parent_io->internal.cb(parent_io, false, parent_io->internal.caller_ctx);

		return;

	}



	if (parent_io->u.bdev.split_remaining_num_blocks == 0) {

		parent_io->internal.status = SPDK_BDEV_IO_STATUS_SUCCESS;

		parent_io->internal.cb(parent_io, SPDK_BDEV_IO_STATUS_SUCCESS, parent_io->internal.caller_ctx);

		parent_io->internal.cb(parent_io, true, parent_io->internal.caller_ctx);

		return;

	}