Commit ba870c2e authored by Seth Howell's avatar Seth Howell Committed by Jim Harris
Browse files

lib/blob: remove some unused internal APIs 



spdk_bs_sequence_unmap and spdk_bs_batch_to_sequence were
unused.

Signed-off-by: default avatarSeth Howell <seth.howell@intel.com>
Change-Id: I4edc45948941ba700bea353c20ddb4e3f2fa15a4
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1701


Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
parent ad7fdd12

lib/blob/request.c

+0 −37
Original line number Diff line number Diff line
@@ -229,24 +229,6 @@ bs_sequence_writev_dev(spdk_bs_sequence_t *seq, struct iovec *iov, int iovcnt, 
			     &set->cb_args);

}



void

spdk_bs_sequence_unmap_dev(spdk_bs_sequence_t *seq,

			   uint64_t lba, uint32_t lba_count,

			   spdk_bs_sequence_cpl cb_fn, void *cb_arg)

{

	struct spdk_bs_request_set      *set = (struct spdk_bs_request_set *)seq;

	struct spdk_bs_channel       *channel = set->channel;



	SPDK_DEBUGLOG(SPDK_LOG_BLOB_RW, "Unmapping %" PRIu32 " blocks at LBA %" PRIu64 "\n", lba_count,

		      lba);



	set->u.sequence.cb_fn = cb_fn;

	set->u.sequence.cb_arg = cb_arg;



	channel->dev->unmap(channel->dev, channel->dev_channel, lba, lba_count,

			    &set->cb_args);

}



void

bs_sequence_write_zeroes_dev(spdk_bs_sequence_t *seq,

			     uint64_t lba, uint32_t lba_count,
@@ -437,25 +419,6 @@ bs_sequence_to_batch(spdk_bs_sequence_t *seq, spdk_bs_sequence_cpl cb_fn, void * 
	return set;

}



spdk_bs_sequence_t *

spdk_bs_batch_to_sequence(spdk_bs_batch_t *batch)

{

	struct spdk_bs_request_set *set = (struct spdk_bs_request_set *)batch;



	set->u.batch.outstanding_ops++;



	set->cpl.type = SPDK_BS_CPL_TYPE_BLOB_BASIC;

	set->cpl.u.blob_basic.cb_fn = bs_sequence_to_batch_completion;

	set->cpl.u.blob_basic.cb_arg = set;

	set->bserrno = 0;



	set->cb_args.cb_fn = spdk_bs_sequence_completion;

	set->cb_args.cb_arg = set;

	set->cb_args.channel = set->channel->dev_channel;



	return (spdk_bs_sequence_t *)set;

}



spdk_bs_user_op_t *

bs_user_op_alloc(struct spdk_io_channel *_channel, struct spdk_bs_cpl *cpl,

		 enum spdk_blob_op_type op_type, struct spdk_blob *blob,

lib/blob/request.h

+0 −6
Original line number Diff line number Diff line
@@ -172,10 +172,6 @@ void bs_sequence_writev_dev(spdk_bs_batch_t *batch, struct iovec *iov, int iovcn 
			    uint64_t lba, uint32_t lba_count,

			    spdk_bs_sequence_cpl cb_fn, void *cb_arg);



void spdk_bs_sequence_unmap_dev(spdk_bs_sequence_t *seq,

				uint64_t lba, uint32_t lba_count,

				spdk_bs_sequence_cpl cb_fn, void *cb_arg);



void bs_sequence_write_zeroes_dev(spdk_bs_sequence_t *seq,

				  uint64_t lba, uint32_t lba_count,

				  spdk_bs_sequence_cpl cb_fn, void *cb_arg);
@@ -208,8 +204,6 @@ spdk_bs_batch_t *bs_sequence_to_batch(spdk_bs_sequence_t *seq, 
				      spdk_bs_sequence_cpl cb_fn,

				      void *cb_arg);



spdk_bs_sequence_t *spdk_bs_batch_to_sequence(spdk_bs_batch_t *batch);



spdk_bs_user_op_t *bs_user_op_alloc(struct spdk_io_channel *channel, struct spdk_bs_cpl *cpl,

				    enum spdk_blob_op_type op_type, struct spdk_blob *blob,

				    void *payload, int iovcnt, uint64_t offset, uint64_t length);