Commit ba67c6f6 authored by Ben Walker's avatar Ben Walker Committed by Darek Stojaczyk
Browse files

check_format: Ban atoi, atol, and atoll 



We can use spdk_strtol and spdk_stroll instead, which do a better job of
catching errors.

Change-Id: I09ff75356b932366b6c10cd6953610f609ce4b0e
Signed-off-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-on: https://review.gerrithub.io/c/441984


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: default avatarDarek Stojaczyk <dariusz.stojaczyk@intel.com>
parent e8207e9d

scripts/check_format.sh

+1 −1
Original line number Diff line number Diff line
@@ -135,7 +135,7 @@ rm -f whitespace.log 


echo -n "Checking for use of forbidden library functions..."



git grep --line-number -w '\(strncpy\|strcpy\|strcat\|sprintf\|vsprintf\)' -- './*.c' ':!lib/vhost/rte_vhost*/**' > badfunc.log || true

git grep --line-number -w '\(atoi\|atol\|atoll\|strncpy\|strcpy\|strcat\|sprintf\|vsprintf\)' -- './*.c' ':!lib/vhost/rte_vhost*/**' > badfunc.log || true

if [ -s badfunc.log ]; then

	echo " Forbidden library functions detected"

	cat badfunc.log