Commit ba3db1d2 authored Jul 26, 2019 by Darek Stojaczyk Committed by Ben Walker Jul 26, 2019

ut/nvme: silence scan-build warnings about null dereference



nvme_ut.c:755:2: warning: Dereference of null pointer
        TAILQ_REMOVE(&probe_ctx.init_ctrlrs, dummy, tailq);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/var/jenkins/workspace/Other/unittest_autotests/spdk/include/spdk/queue.h:62:6:
note: expanded from macro 'TAILQ_REMOVE'
        if (((elm)->field.tqe_next) != NULL)

Change-Id: I8ee6a476f2658668304e182a6c8cff4d79ae2f40
Signed-off-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/463257


Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Paul Luse <paul.e.luse@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>

parent b701087f

test/unit/lib/nvme/nvme.c/nvme_ut.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -751,6 +751,7 @@ test_nvme_ctrlr_probe(void)
		rc = nvme_ctrlr_probe(&trid, &probe_ctx, devhandle);
		CU_ASSERT(rc == 0);
		dummy = TAILQ_FIRST(&probe_ctx.init_ctrlrs);
		SPDK_CU_ASSERT_FATAL(dummy != NULL);
		CU_ASSERT(dummy == ut_nvme_transport_ctrlr_construct);
		TAILQ_REMOVE(&probe_ctx.init_ctrlrs, dummy, tailq);
		MOCK_CLEAR_P(nvme_transport_ctrlr_construct);