Commit b994a06a authored by Mike Gerdts's avatar Mike Gerdts Committed by Konrad Sztyber
Browse files

bdev: bdev_abort_all_buf_io called too many times 



Commit 5a3e64ef changed the
implementation of bdev_abort_all_buf_io() such that it is no longer
necessary to call it multiple times to abort small and large IOs. When
modifying callers of bdev_abort_all_buf_io(), it should have retained
only one call to bdev_abort_all_buf_io().

This commit eliminates the extraneous calls to bdev_abort_all_buf_io().

Signed-off-by: default avatarMike Gerdts <mgerdts@nvidia.com>
Change-Id: If030bbbb1428d1fc51b78dc5c055c6002deb960c
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18136


Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Mellanox Build Bot
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
parent 866e7b13

lib/bdev/bdev.c

+0 −2
Original line number Diff line number Diff line
@@ -4385,7 +4385,6 @@ bdev_channel_abort_queued_ios(struct spdk_bdev_channel *ch) 


	bdev_abort_all_queued_io(&shared_resource->nomem_io, ch);

	bdev_abort_all_buf_io(mgmt_ch, ch);

	bdev_abort_all_buf_io(mgmt_ch, ch);

}



static void
@@ -6288,7 +6287,6 @@ bdev_reset_freeze_channel(struct spdk_bdev_channel_iter *i, struct spdk_bdev *bd 


	bdev_abort_all_queued_io(&shared_resource->nomem_io, channel);

	bdev_abort_all_buf_io(mgmt_channel, channel);

	bdev_abort_all_buf_io(mgmt_channel, channel);

	bdev_abort_all_queued_io(&tmp_queued, channel);



	spdk_bdev_for_each_channel_continue(i, 0);