Commit b98f5c24 authored by Pawel Kaminski's avatar Pawel Kaminski Committed by Tomasz Zawadzki
Browse files

scripts/setup.sh: Fix. Variable virtio_names used as array contains empty first element. 



It fixes change 474989.

"for blkname in $blknames; do"
was changed to
"for blkname in "${blknames[@]}"; do"
if blknames=" vda" then first blkname="" and
linux_bind_driver is called for vda although it has active mountpoint

Change-Id: I16d4379db274faa5703230072cfcf8d18a8ef5e6
Signed-off-by: default avatarPawel Kaminski <pawelx.kaminski@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/476061


Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
parent d453c940

scripts/setup.sh

+3 −3
Original line number Diff line number Diff line
@@ -159,15 +159,15 @@ function get_nvme_name_from_bdf { 


function get_virtio_names_from_bdf {

	blk_devs=$(lsblk --nodeps --output NAME)

	virtio_names=''

	virtio_names=()



	for dev in $blk_devs; do

		if readlink "/sys/block/$dev" | grep -q "$1"; then

			virtio_names="$virtio_names $dev"

			virtio_names+=("$dev")

		fi

	done



	eval "$2='$virtio_names'"

	eval "$2=( " "${virtio_names[@]}" " )"

}



function configure_linux_pci {