Commit b9792a95 authored by Artur Paszkiewicz's avatar Artur Paszkiewicz Committed by Tomasz Zawadzki
Browse files

module/raid: add missing uuid information 



Add comments and documentation where necessary, also include the UUID in
JSON raid bdev information.

Change-Id: Ic5ef84d249dd60c9249767c93d27010f4eb7aaf6
Signed-off-by: default avatarArtur Paszkiewicz <artur.paszkiewicz@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20364


Reviewed-by: default avatarJim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
parent 5da1742b

doc/jsonrpc.md

+3 −0
Original line number Diff line number Diff line
@@ -10352,6 +10352,7 @@ Example response: 
  "result": [

    {

      "name": "RaidBdev0",

      "uuid": "7d352e83-fe27-40f2-8fef-64563355e076",

      "strip_size_kb": 128,

      "state": "online",

      "raid_level": "raid0",
@@ -10364,6 +10365,7 @@ Example response: 
    },

    {

      "name": "RaidBdev1",

      "uuid": "f7cb71ed-2d0e-4240-979e-27b0b7735f36",

      "strip_size_kb": 128,

      "state": "configuring",

      "raid_level": "raid0",
@@ -10390,6 +10392,7 @@ name | Required | string | RAID bdev name 
strip_size_kb           | Required | number      | Strip size in KB

raid_level              | Required | string      | RAID level

base_bdevs              | Required | string      | Base bdevs name, whitespace separated list in quotes

uuid                    | Optional | string      | UUID for this RAID bdev



#### Example

module/bdev/raid/bdev_raid.c

+7 −0
Original line number Diff line number Diff line
@@ -596,10 +596,13 @@ void 
raid_bdev_write_info_json(struct raid_bdev *raid_bdev, struct spdk_json_write_ctx *w)

{

	struct raid_base_bdev_info *base_info;

	char uuid_str[SPDK_UUID_STRING_LEN];



	assert(raid_bdev != NULL);

	assert(spdk_get_thread() == spdk_thread_get_app_thread());



	spdk_uuid_fmt_lower(uuid_str, sizeof(uuid_str), &raid_bdev->bdev.uuid);

	spdk_json_write_named_string(w, "uuid", uuid_str);

	spdk_json_write_named_uint32(w, "strip_size_kb", raid_bdev->strip_size_kb);

	spdk_json_write_named_string(w, "state", raid_bdev_state_to_str(raid_bdev->state));

	spdk_json_write_named_string(w, "raid_level", raid_bdev_level_to_str(raid_bdev->level));
@@ -656,6 +659,7 @@ raid_bdev_write_config_json(struct spdk_bdev *bdev, struct spdk_json_write_ctx * 
{

	struct raid_bdev *raid_bdev = bdev->ctxt;

	struct raid_base_bdev_info *base_info;

	char uuid_str[SPDK_UUID_STRING_LEN];



	assert(spdk_get_thread() == spdk_thread_get_app_thread());
@@ -665,6 +669,8 @@ raid_bdev_write_config_json(struct spdk_bdev *bdev, struct spdk_json_write_ctx * 


	spdk_json_write_named_object_begin(w, "params");

	spdk_json_write_named_string(w, "name", bdev->name);

	spdk_uuid_fmt_lower(uuid_str, sizeof(uuid_str), &raid_bdev->bdev.uuid);

	spdk_json_write_named_string(w, "uuid", uuid_str);

	spdk_json_write_named_uint32(w, "strip_size_kb", raid_bdev->strip_size_kb);

	spdk_json_write_named_string(w, "raid_level", raid_bdev_level_to_str(raid_bdev->level));
@@ -932,6 +938,7 @@ raid_bdev_init(void) 
 * num_base_bdevs - number of base bdevs

 * level - raid level

 * raid_bdev_out - the created raid bdev

 * uuid - uuid to set for the bdev

 * returns:

 * 0 - success

 * non zero - failure