Commit b942f8f5 authored by Mao Jiang's avatar Mao Jiang Committed by Tomasz Zawadzki
Browse files

test/nvmf/subsystem: cases for adding host subsystem 



Change-Id: I5a31c5abb9257ce9315a9b15d3434a7687be0070
Signed-off-by: default avatarMao Jiang <maox.jiang@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/8725


Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@mellanox.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
parent 19f0bfd6

test/unit/lib/nvmf/subsystem.c/subsystem_ut.c

+38 −0
Original line number Diff line number Diff line
@@ -1464,6 +1464,43 @@ test_nvmf_subsystem_add_ctrlr(void) 
	free(tgt.subsystems);

}



static void

test_spdk_nvmf_subsystem_add_host(void)

{

	struct spdk_nvmf_tgt tgt = {};

	struct spdk_nvmf_subsystem *subsystem = NULL;

	int rc;

	const char hostnqn[] = "nqn.2016-06.io.spdk:host1";

	const char subsystemnqn[] = "nqn.2016-06.io.spdk:subsystem1";



	tgt.max_subsystems = 1024;

	tgt.subsystems = calloc(tgt.max_subsystems, sizeof(struct spdk_nvmf_subsystem *));

	SPDK_CU_ASSERT_FATAL(tgt.subsystems != NULL);



	subsystem = spdk_nvmf_subsystem_create(&tgt, subsystemnqn, SPDK_NVMF_SUBTYPE_NVME, 0);

	SPDK_CU_ASSERT_FATAL(subsystem != NULL);

	CU_ASSERT_STRING_EQUAL(subsystem->subnqn, subsystemnqn);



	rc = spdk_nvmf_subsystem_add_host(subsystem, hostnqn);

	CU_ASSERT(rc == 0);

	CU_ASSERT(!TAILQ_EMPTY(&subsystem->hosts));



	/* Add existing nqn, this function is allowed to be called if the nqn was previously added. */

	rc = spdk_nvmf_subsystem_add_host(subsystem, hostnqn);

	CU_ASSERT(rc == 0);



	rc = spdk_nvmf_subsystem_remove_host(subsystem, hostnqn);

	CU_ASSERT(rc == 0);

	CU_ASSERT(TAILQ_EMPTY(&subsystem->hosts));



	/* No available nqn */

	rc = spdk_nvmf_subsystem_remove_host(subsystem, hostnqn);

	CU_ASSERT(rc == -ENOENT);



	spdk_nvmf_subsystem_destroy(subsystem);

	free(tgt.subsystems);

}



int main(int argc, char **argv)

{

	CU_pSuite	suite = NULL;
@@ -1490,6 +1527,7 @@ int main(int argc, char **argv) 
	CU_ADD_TEST(suite, test_spdk_nvmf_ns_event);

	CU_ADD_TEST(suite, test_nvmf_ns_reservation_add_remove_registrant);

	CU_ADD_TEST(suite, test_nvmf_subsystem_add_ctrlr);

	CU_ADD_TEST(suite, test_spdk_nvmf_subsystem_add_host);



	allocate_threads(1);

	set_thread(0);